The following document contains the results of FindBugs Report
FindBugs Version is 1.1.1
Threshold is Normal
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 395 | 24 | 33 | 20 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Uninitialized read of parent in org.apache.commons.dbcp.AbandonedTrace.AbandonedTrace() | CORRECTNESS | UR_UNINIT_READ | 62 |
| Uninitialized read of parent in org.apache.commons.dbcp.AbandonedTrace.AbandonedTrace(AbandonedConfig) | CORRECTNESS | UR_UNINIT_READ | 72 |
| Unwritten field: org.apache.commons.dbcp.AbandonedTrace.parent | CORRECTNESS | UWF_UNWRITTEN_FIELD | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.commons.dbcp.DelegatingCallableStatement defines equals but not hashCode | BAD_PRACTICE | HE_EQUALS_NO_HASHCODE | 74-83 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.commons.dbcp.DelegatingPreparedStatement defines equals but not hashCode | BAD_PRACTICE | HE_EQUALS_NO_HASHCODE | 71-80 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from java.sql.Statement to org.apache.commons.dbcp.AbandonedTrace in org.apache.commons.dbcp.DelegatingResultSet.DelegatingResultSet(java.sql.Statement,java.sql.ResultSet) | STYLE | BC_UNCONFIRMED_CAST | 72 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Inconsistent synchronization of org.apache.commons.dbcp.PoolableConnectionFactory._validationQuery; locked % of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 330 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.commons.dbcp.PoolingConnection.createKey(String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 177 |
| org.apache.commons.dbcp.PoolingConnection.createKey(String,int,int) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 166 |
| Possible null pointer dereference of org.apache.commons.dbcp.PoolingConnection$PStmtKey._resultSetType in org.apache.commons.dbcp.PoolingConnection.makeObject(Object) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 203 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.commons.dbcp.PoolingConnection$PStmtKey be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.commons.dbcp.PoolingDriver$PoolGuardConnectionWrapper be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.commons.dbcp.SQLNestedException.<static initializer>() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 41 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Class org.apache.commons.dbcp.cpdsadapter.DriverAdapterCPDS defines non-transient non-serializable instance field logWriter | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Possible null pointer dereference of org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl$PStmtKey._resultSetType in org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl.makeObject(Object) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 286 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.commons.dbcp.cpdsadapter.PooledConnectionImpl$PStmtKey be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Inconsistent synchronization of org.apache.commons.dbcp.datasources.CPDSConnectionFactory._pool; locked % of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 293 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Inconsistent synchronization of org.apache.commons.dbcp.datasources.KeyedCPDSConnectionFactory._pool; locked % of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 299 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.commons.dbcp.datasources.PerUserPoolDataSource.pools is transient but org.apache.commons.dbcp.datasources.PerUserPoolDataSource isn't Serializable | STYLE | SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The field org.apache.commons.dbcp.datasources.SequencedHashMap.modCount is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.commons.dbcp.datasources.SequencedHashMap$OrderedIterator.expectedModCount is transient but org.apache.commons.dbcp.datasources.SequencedHashMap$OrderedIterator isn't Serializable | STYLE | SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.commons.jocl.JOCLContentHandler.startElement(String,String,String,org.xml.sax.Attributes) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 435 |
| Method org.apache.commons.jocl.JOCLContentHandler.startElement(String,String,String,org.xml.sax.Attributes) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 474 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.commons.jocl.JOCLContentHandler$ConstructorDetails be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |