PMD Results

The following document contains the results of PMD 4.1.

Files

org/apache/commons/jjar/ClasspathUtil.java

Violation Line
Avoid importing anything from the package 'java.lang' 19
Avoid unused imports such as 'java.lang.Package' 19
Avoid unused imports such as 'java.util.Collection' 23
Avoid unused imports such as 'java.util.Map' 24
Avoid unused imports such as 'java.util.jar.JarInputStream' 32
Avoid unused imports such as 'java.io.BufferedInputStream' 38
Avoid unused imports such as 'java.io.BufferedOutputStream' 39
Avoid unnecessary return statements 81
Avoid empty catch blocks 115 - 118

org/apache/commons/jjar/DependencyEngine.java

Violation Line
Avoid importing anything from the package 'java.lang' 23
Avoid empty if statements 365 - 367
Avoid unnecessary return statements 388
Avoid empty if statements 433 - 435
Avoid unnecessary return statements 449
Avoid unused private fields such as 'name'. 461

org/apache/commons/jjar/JJAR.java

Violation Line
Avoid unused local variables such as 'classpath'. 80
Avoid empty catch blocks 225 - 228
These nested if statements could be combined 232 - 236
Avoid empty catch blocks 281 - 284
Avoid empty catch blocks 333 - 335
Avoid empty catch blocks 360 - 362
Avoid unnecessary return statements 370

org/apache/commons/jjar/JJARPackage.java

Violation Line
Avoid unused private fields such as 'properties'. 39
Avoid unused private fields such as 'DESC'. 41
Avoid unused private fields such as 'JAR'. 42
Avoid unused private fields such as 'HREF'. 43
Invoke equals() on the object you've already ensured is not null 90
These nested if statements could be combined 94 - 97

org/apache/commons/jjar/Repository.java

Violation Line
Avoid unused imports such as 'java.util.Properties' 19
Avoid unused imports such as 'java.util.StringTokenizer' 20
Avoid unused imports such as 'java.util.ArrayList' 21
Avoid unused imports such as 'java.io.InputStream' 25
Avoid unused imports such as 'java.net.URLConnection' 28

org/apache/commons/jjar/RepositoryProps.java

Violation Line
Avoid empty catch blocks 46 - 48

org/apache/commons/jjar/RepositoryXML.java

Violation Line
Avoid unused imports such as 'java.util.Properties' 19
These nested if statements could be combined 211 - 215
Avoid unused private methods such as 'makeList(String)'. 267
Avoid empty catch blocks 429 - 430
Avoid empty catch blocks 466 - 467
Avoid unused private methods such as 'dumpPackageInfo(Map)'. 481
Avoid empty catch blocks 579 - 580
Avoid unused private methods such as 'show(String,Map)'. 670

org/apache/commons/jjar/Transport.java

Violation Line
Avoid importing anything from the package 'java.lang' 20
Avoid unused imports such as 'java.lang.Package' 20
Avoid unused imports such as 'java.util.ArrayList' 22
Avoid unused imports such as 'java.util.Iterator' 23
Avoid unused imports such as 'java.util.Collection' 24
Avoid unused imports such as 'java.util.Map' 25
Avoid unused imports such as 'java.util.List' 26
Avoid unused imports such as 'java.util.StringTokenizer' 27
Avoid unused imports such as 'java.util.jar.JarFile' 28
Avoid unused imports such as 'java.util.jar.Manifest' 29
Avoid unused imports such as 'java.util.jar.Attributes' 30
Avoid unused imports such as 'java.util.jar.JarInputStream' 31
Avoid unused imports such as 'java.io.File' 33
Avoid unused imports such as 'java.net.JarURLConnection' 40
Avoid unused imports such as 'java.net.URL' 42
Avoid empty catch blocks 74

org/apache/commons/jjar/Version.java

Violation Line
Avoid empty catch blocks 109 - 110
Avoid empty catch blocks 124 - 125