Apache Commons logo Commons BeanUtils

FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is

Effort is min

Summary

Classes Bugs Errors Missing Classes
137 64 0 0

org.apache.commons.beanutils.BasicDynaBean

Bug Category Details Line Priority
org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 160 Medium
org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 162 Medium
org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 168 Medium
org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 170 Medium
org.apache.commons.beanutils.BasicDynaBean.get(String) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 172 Medium
org.apache.commons.beanutils.BasicDynaBean is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 57-439 Medium

org.apache.commons.beanutils.BasicDynaClass

Bug Category Details Line Priority
org.apache.commons.beanutils.BasicDynaClass.getDynaProperties() may expose internal representation by returning BasicDynaClass.properties MALICIOUS_CODE EI_EXPOSE_REP 196 Medium
org.apache.commons.beanutils.BasicDynaClass.constructorTypes should be both final and package protected MALICIOUS_CODE MS_FINAL_PKGPROTECT 107 Medium
org.apache.commons.beanutils.BasicDynaClass is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 50-300 Medium

org.apache.commons.beanutils.BeanMap$3

Bug Category Details Line Priority
org.apache.commons.beanutils.BeanMap$3.transform(Object) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 144 Medium

org.apache.commons.beanutils.ContextClassLoaderLocal

Bug Category Details Line Priority
Return value of java.util.Map.isEmpty() ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 146 Medium
Return value of java.util.Map.isEmpty() ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 183 Medium

org.apache.commons.beanutils.ConvertUtilsBean

Bug Category Details Line Priority
org.apache.commons.beanutils.ConvertUtilsBean.<static initializer for ConvertUtilsBean>() invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 130 Medium
org.apache.commons.beanutils.ConvertUtilsBean.<static initializer for ConvertUtilsBean>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 129 Medium
org.apache.commons.beanutils.ConvertUtilsBean.<static initializer for ConvertUtilsBean>() invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 406 Medium
new org.apache.commons.beanutils.ConvertUtilsBean() invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 205 Medium
new org.apache.commons.beanutils.ConvertUtilsBean() invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 238 Medium
new org.apache.commons.beanutils.ConvertUtilsBean() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 339 Medium
new org.apache.commons.beanutils.ConvertUtilsBean() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 372 Medium
org.apache.commons.beanutils.ConvertUtilsBean.setDefaultByte(byte) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 227 Medium
org.apache.commons.beanutils.ConvertUtilsBean.setDefaultCharacter(char) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 260 Medium
org.apache.commons.beanutils.ConvertUtilsBean.setDefaultInteger(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 361 Medium
org.apache.commons.beanutils.ConvertUtilsBean.setDefaultLong(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 394 Medium
org.apache.commons.beanutils.ConvertUtilsBean.setDefaultShort(short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 427 Medium
Write to static field org.apache.commons.beanutils.ConvertUtilsBean.defaultShort from instance method org.apache.commons.beanutils.ConvertUtilsBean.setDefaultShort(short) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 427 High

org.apache.commons.beanutils.LazyDynaBean

Bug Category Details Line Priority
org.apache.commons.beanutils.LazyDynaBean.<static initializer for LazyDynaBean>() invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 139 Medium
org.apache.commons.beanutils.LazyDynaBean.<static initializer for LazyDynaBean>() invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 137 Medium
org.apache.commons.beanutils.LazyDynaBean.<static initializer for LazyDynaBean>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 143 Medium
org.apache.commons.beanutils.LazyDynaBean.<static initializer for LazyDynaBean>() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 145 Medium
org.apache.commons.beanutils.LazyDynaBean.<static initializer for LazyDynaBean>() invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 141 Medium
org.apache.commons.beanutils.LazyDynaBean is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 130-952 Medium

org.apache.commons.beanutils.LazyDynaList

Bug Category Details Line Priority
org.apache.commons.beanutils.LazyDynaList is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 195-716 Medium

org.apache.commons.beanutils.MappedPropertyDescriptor

Bug Category Details Line Priority
org.apache.commons.beanutils.MappedPropertyDescriptor doesn't override java.beans.PropertyDescriptor.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.apache.commons.beanutils.PropertyUtilsBean

Bug Category Details Line Priority
org.apache.commons.beanutils.PropertyUtilsBean.getIndexedProperty(Object, String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 519 Medium
org.apache.commons.beanutils.PropertyUtilsBean.setIndexedProperty(Object, String, int, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 1637 Medium
org.apache.commons.beanutils.PropertyUtilsBean.invokeMethod(Method, Object, Object[]) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 2141 Medium

org.apache.commons.beanutils.WeakFastHashMap$CollectionView

Bug Category Details Line Priority
org.apache.commons.beanutils.WeakFastHashMap$CollectionView.equals(Object) is unusual STYLE EQ_UNUSUAL 628-636 Medium

org.apache.commons.beanutils.WrapDynaBean

Bug Category Details Line Priority
org.apache.commons.beanutils.WrapDynaBean is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 61-406 Medium

org.apache.commons.beanutils.WrapDynaClass

Bug Category Details Line Priority
org.apache.commons.beanutils.WrapDynaClass.getDynaProperties() may expose internal representation by returning WrapDynaClass.properties MALICIOUS_CODE EI_EXPOSE_REP 327 Medium
Unread public/protected field: org.apache.commons.beanutils.WrapDynaClass.beanClass STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 95 Medium
Unread public/protected field: org.apache.commons.beanutils.WrapDynaClass.descriptors STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 102 Medium
org.apache.commons.beanutils.WrapDynaClass.introspect() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 483 Medium

org.apache.commons.beanutils.converters.AbstractArrayConverter

Bug Category Details Line Priority
org.apache.commons.beanutils.converters.AbstractArrayConverter.strings isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 104 Medium

org.apache.commons.beanutils.converters.AbstractConverter

Bug Category Details Line Priority
Load of known null value in org.apache.commons.beanutils.converters.AbstractConverter.convert(Class, Object) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 133 Medium
org.apache.commons.beanutils.converters.AbstractConverter.toString(Class) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 431 Medium

org.apache.commons.beanutils.converters.ArrayConverter

Bug Category Details Line Priority
org.apache.commons.beanutils.converters.ArrayConverter.setAllowedChars(char[]) may expose internal representation by storing an externally mutable object into ArrayConverter.allowedChars MALICIOUS_CODE EI_EXPOSE_REP2 204 Medium

org.apache.commons.beanutils.converters.CharacterConverter

Bug Category Details Line Priority
org.apache.commons.beanutils.converters.CharacterConverter.convertToType(Class, Object) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 89 Medium

org.apache.commons.beanutils.converters.DateTimeConverter

Bug Category Details Line Priority
org.apache.commons.beanutils.converters.DateTimeConverter.getPatterns() may expose internal representation by returning DateTimeConverter.patterns MALICIOUS_CODE EI_EXPOSE_REP 187 Medium
org.apache.commons.beanutils.converters.DateTimeConverter.setPatterns(String[]) may expose internal representation by storing an externally mutable object into DateTimeConverter.patterns MALICIOUS_CODE EI_EXPOSE_REP2 198 Medium

org.apache.commons.beanutils.converters.NumberConverter

Bug Category Details Line Priority
org.apache.commons.beanutils.converters.NumberConverter.<static initializer for NumberConverter>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 91 Medium
org.apache.commons.beanutils.converters.NumberConverter.convertToType(Class, Object) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 252 Medium
org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, Number) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 322 Medium
org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, Number) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 350 Medium
org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, Number) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 355 Medium
org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, Number) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 336 Medium
org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, String) invokes inefficient new Byte(String) constructor; use Byte.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 427 Medium
org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 437 Medium
org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 442 Medium
org.apache.commons.beanutils.converters.NumberConverter.toNumber(Class, Class, String) invokes inefficient new Short(String) constructor; use Short.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 432 Medium

org.apache.commons.beanutils.locale.LocaleBeanUtilsBean$Descriptor

Bug Category Details Line Priority
Should org.apache.commons.beanutils.locale.LocaleBeanUtilsBean$Descriptor be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 949-1061 Medium

org.apache.commons.beanutils.locale.converters.ByteLocaleConverter

Bug Category Details Line Priority
org.apache.commons.beanutils.locale.converters.ByteLocaleConverter.parse(Object, String) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 223 Medium

org.apache.commons.beanutils.locale.converters.IntegerLocaleConverter

Bug Category Details Line Priority
org.apache.commons.beanutils.locale.converters.IntegerLocaleConverter.parse(Object, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 223 Medium

org.apache.commons.beanutils.locale.converters.LongLocaleConverter

Bug Category Details Line Priority
org.apache.commons.beanutils.locale.converters.LongLocaleConverter.parse(Object, String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 224 Medium

org.apache.commons.beanutils.locale.converters.ShortLocaleConverter

Bug Category Details Line Priority
org.apache.commons.beanutils.locale.converters.ShortLocaleConverter.parse(Object, String) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 230 Medium