PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
1227

Files

FilesViolations
org/apache/commons/jelly/tags/ant/AntTag.java 13
org/apache/commons/jelly/tags/ant/FileIterator.java 1
org/apache/commons/jelly/tags/ant/FileScanner.java 1
org/apache/commons/jelly/tags/ant/FileScannerTag.java 1
org/apache/commons/jelly/tags/ant/GrantProject.java 3
org/apache/commons/jelly/tags/ant/JellyPropsHandler.java 1
org/apache/commons/jelly/tags/ant/SetPropertyTag.java 1
org/apache/commons/jelly/task/AntJellyContext.java 2
org/apache/commons/jelly/ant/TestJelly.java 1
org/apache/commons/jelly/ant/tag/DummyTag.java 1
org/apache/commons/jelly/ant/tag/TestJelly.java 1
org/apache/commons/jelly/ant/task/DummyTask.java 1

org/apache/commons/jelly/tags/ant/AntTag.java

ViolationLine
The class 'AntTag' has a Cyclomatic Complexity of 3 (Highest = 17). 53
Avoid unused private fields such as 'ANT_MANIFEST_TAG' 61
Avoid really long methods. 108
The method 'doTag' has a Cyclomatic Complexity of 17. 108
Deeply nested if..then statements are hard to read 132
Avoid if (x != y) ..; else ..; 218
Avoid unused local variables such as 'body' 237
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 253
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 361
Avoid empty catch blocks 364
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 399
The String literal "datatype '" appears 4 times in this file; the first occurrence is on line 442 442
Avoid unused private methods such as 'createDataType' 468

org/apache/commons/jelly/tags/ant/FileIterator.java

ViolationLine
These nested if statements could be combined 88

org/apache/commons/jelly/tags/ant/FileScanner.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 35

org/apache/commons/jelly/tags/ant/FileScannerTag.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 36

org/apache/commons/jelly/tags/ant/GrantProject.java

ViolationLine
Use block level rather than method level synchronization 105
Use block level rather than method level synchronization 114
Use block level rather than method level synchronization 123

org/apache/commons/jelly/tags/ant/JellyPropsHandler.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 34

org/apache/commons/jelly/tags/ant/SetPropertyTag.java

ViolationLine
Avoid unused private fields such as 'log' 37

org/apache/commons/jelly/task/AntJellyContext.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 37
Private field could be made final. It is only initialized in the declaration or constructor. 40

org/apache/commons/jelly/ant/TestJelly.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 38

org/apache/commons/jelly/ant/tag/DummyTag.java

ViolationLine
Avoid unused private fields such as 'flag' 47

org/apache/commons/jelly/ant/tag/TestJelly.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 38

org/apache/commons/jelly/ant/task/DummyTask.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 76