PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
3069

Files

FilesViolations
org/apache/commons/jelly/tags/swing/ActionTag.java 3
org/apache/commons/jelly/tags/swing/BeanFactory.java 1
org/apache/commons/jelly/tags/swing/BorderLayoutTag.java 1
org/apache/commons/jelly/tags/swing/BorderTagSupport.java 2
org/apache/commons/jelly/tags/swing/ButtonGroupTag.java 1
org/apache/commons/jelly/tags/swing/ComponentTag.java 11
org/apache/commons/jelly/tags/swing/ConstraintTag.java 1
org/apache/commons/jelly/tags/swing/DialogTag.java 2
org/apache/commons/jelly/tags/swing/EmptyBorderTag.java 1
org/apache/commons/jelly/tags/swing/EtchedBorderTag.java 1
org/apache/commons/jelly/tags/swing/FocusListenerTag.java 1
org/apache/commons/jelly/tags/swing/FontTag.java 2
org/apache/commons/jelly/tags/swing/GbcTag.java 5
org/apache/commons/jelly/tags/swing/GridBagLayoutTag.java 1
org/apache/commons/jelly/tags/swing/KeyListenerTag.java 1
org/apache/commons/jelly/tags/swing/LayoutTagSupport.java 1
org/apache/commons/jelly/tags/swing/SwingTagLibrary.java 3
org/apache/commons/jelly/tags/swing/TableLayoutTag.java 1
org/apache/commons/jelly/tags/swing/TdTag.java 1
org/apache/commons/jelly/tags/swing/TitledBorderTag.java 3
org/apache/commons/jelly/tags/swing/TrTag.java 2
org/apache/commons/jelly/tags/swing/WindowListenerTag.java 1
org/apache/commons/jelly/tags/swing/converters/DebugGraphicsConverter.java 2
org/apache/commons/jelly/tags/swing/converters/DimensionConverter.java 1
org/apache/commons/jelly/tags/swing/converters/PointConverter.java 1
org/apache/commons/jelly/tags/swing/impl/GridBagConstraintBean.java 9
org/apache/commons/jelly/tags/swing/model/ExpressionTableModel.java 2
org/apache/commons/jelly/core/BaseJellyTest.java 1
org/apache/commons/jelly/swing/MyTableModel.java 6
org/apache/commons/jelly/swing/TestConverters.java 1

org/apache/commons/jelly/tags/swing/ActionTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 86
Avoid if (x != y) ..; else ..; 123
Avoid if (x != y) ..; else ..; 128

org/apache/commons/jelly/tags/swing/BeanFactory.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 26

org/apache/commons/jelly/tags/swing/BorderLayoutTag.java

ViolationLine
Avoid unused private fields such as 'log' 33

org/apache/commons/jelly/tags/swing/BorderTagSupport.java

ViolationLine
Avoid unused private fields such as 'log' 36
Avoid if (x != y) ..; else ..; 56

org/apache/commons/jelly/tags/swing/ButtonGroupTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 76

org/apache/commons/jelly/tags/swing/ComponentTag.java

ViolationLine
The class 'ComponentTag' has a Cyclomatic Complexity of 3 (Highest = 12). 64
Avoid unused private fields such as 'log' 67
Avoid if (x != y) ..; else ..; 87
Avoid unused private fields such as 'currentOutput' 175
The method 'addChild' has a Cyclomatic Complexity of 12. 236
Avoid if (x != y) ..; else ..; 244
Avoid if (x != y) ..; else ..; 280
Avoid if (x != y) ..; else ..; 318
Avoid if (x != y) ..; else ..; 341
The method 'setBeanProperties' has a Cyclomatic Complexity of 10. 355
The String literal "debugGraphicsOptions" appears 4 times in this file; the first occurrence is on line 392 392

org/apache/commons/jelly/tags/swing/ConstraintTag.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 63

org/apache/commons/jelly/tags/swing/DialogTag.java

ViolationLine
Avoid unused private fields such as 'log' 41
Avoid if (x != y) ..; else ..; 73

org/apache/commons/jelly/tags/swing/EmptyBorderTag.java

ViolationLine
Avoid unused private fields such as 'log' 38

org/apache/commons/jelly/tags/swing/EtchedBorderTag.java

ViolationLine
These nested if statements could be combined 56

org/apache/commons/jelly/tags/swing/FocusListenerTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 100

org/apache/commons/jelly/tags/swing/FontTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 67
Avoid if (x != y) ..; else ..; 73

org/apache/commons/jelly/tags/swing/GbcTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 99
No need to check for null before an instanceof 163
Deeply nested if..then statements are hard to read 165
Avoid reassigning parameters such as 'from' 175
Use equals() to compare object references. 178

org/apache/commons/jelly/tags/swing/GridBagLayoutTag.java

ViolationLine
Avoid unused private fields such as 'log' 33

org/apache/commons/jelly/tags/swing/KeyListenerTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 99

org/apache/commons/jelly/tags/swing/LayoutTagSupport.java

ViolationLine
Avoid unused private fields such as 'log' 37

org/apache/commons/jelly/tags/swing/SwingTagLibrary.java

ViolationLine
Avoid unused private fields such as 'log' 118
A high number of imports can indicate a high degree of coupling within an object. 300
A value of 60 may denote a high amount of coupling within the class 300

org/apache/commons/jelly/tags/swing/TableLayoutTag.java

ViolationLine
Avoid unused private fields such as 'log' 36

org/apache/commons/jelly/tags/swing/TdTag.java

ViolationLine
Avoid unused private fields such as 'log' 37

org/apache/commons/jelly/tags/swing/TitledBorderTag.java

ViolationLine
Avoid unused private fields such as 'log' 42
Avoid if (x != y) ..; else ..; 116
Deeply nested if..then statements are hard to read 116

org/apache/commons/jelly/tags/swing/TrTag.java

ViolationLine
Avoid unused private fields such as 'log' 41
Private field could be made final. It is only initialized in the declaration or constructor. 44

org/apache/commons/jelly/tags/swing/WindowListenerTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 164

org/apache/commons/jelly/tags/swing/converters/DebugGraphicsConverter.java

ViolationLine
Avoid reassigning parameters such as 'value' 68
Avoid calling toString() on String objects; this is unnecessary 69

org/apache/commons/jelly/tags/swing/converters/DimensionConverter.java

ViolationLine
Avoid reassigning parameters such as 'text' 50

org/apache/commons/jelly/tags/swing/converters/PointConverter.java

ViolationLine
Avoid reassigning parameters such as 'text' 50

org/apache/commons/jelly/tags/swing/impl/GridBagConstraintBean.java

ViolationLine
The class 'GridBagConstraintBean' has a Cyclomatic Complexity of 3 (Highest = 18). 33
The method 'getAnchor' has a Cyclomatic Complexity of 18. 132
A switch statement does not contain a break 133
Switch statements should have a default label 133
The method 'setAnchor' has a Cyclomatic Complexity of 18. 180
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 181
A switch statement does not contain a break 227
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 247
The method 'setBasedOn' has a Cyclomatic Complexity of 11. 264

org/apache/commons/jelly/tags/swing/model/ExpressionTableModel.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 38
An empty statement (semicolon) not part of a loop 103

org/apache/commons/jelly/core/BaseJellyTest.java

ViolationLine
This abstract class does not have any abstract methods 30

org/apache/commons/jelly/swing/MyTableModel.java

ViolationLine
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 47
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 49
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 51
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 53
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 55
Avoid unnecessary if..then..else statements when returning a boolean 91

org/apache/commons/jelly/swing/TestConverters.java

ViolationLine
Avoid unused private fields such as 'log' 42