PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
940

Files

FilesViolations
org/apache/commons/jelly/tags/threads/GroupTag.java 1
org/apache/commons/jelly/tags/threads/JellyThread.java 2
org/apache/commons/jelly/tags/threads/Mutex.java 6
org/apache/commons/jelly/tags/threads/NotifyTag.java 1
org/apache/commons/jelly/tags/threads/RunnableStatus.java 15
org/apache/commons/jelly/tags/threads/ThreadTag.java 6
org/apache/commons/jelly/tags/threads/UseThreadTag.java 4
org/apache/commons/jelly/tags/threads/WaitForTag.java 4
org/apache/commons/jelly/threads/TestJelly.java 1

org/apache/commons/jelly/tags/threads/GroupTag.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 39

org/apache/commons/jelly/tags/threads/JellyThread.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 32
The String literal "Thread \"" appears 5 times in this file; the first occurrence is on line 66 66

org/apache/commons/jelly/tags/threads/Mutex.java

ViolationLine
Call Thread.notifyAll() rather than Thread.notify() 137
Use block level rather than method level synchronization 143
Call Thread.notifyAll() rather than Thread.notify() 145
Avoid if (x != y) ..; else ..; 152
Avoid if (x != y) ..; else ..; 163
Call Thread.notifyAll() rather than Thread.notify() 173

org/apache/commons/jelly/tags/threads/NotifyTag.java

ViolationLine
Call Thread.notifyAll() rather than Thread.notify() 37

org/apache/commons/jelly/tags/threads/RunnableStatus.java

ViolationLine
Overridable method 'set' called during construction 43
Use block level rather than method level synchronization 46
Use block level rather than method level synchronization 50
Use block level rather than method level synchronization 62
Use block level rather than method level synchronization 66
Use block level rather than method level synchronization 70
Use block level rather than method level synchronization 74
Use block level rather than method level synchronization 78
Use block level rather than method level synchronization 82
Use block level rather than method level synchronization 86
Ensure you override both equals() and hashCode() 90
Use block level rather than method level synchronization 90
Ensure you override both equals() and hashCode() 94
Use block level rather than method level synchronization 94
Avoid unnecessary if..then..else statements when returning a boolean 148

org/apache/commons/jelly/tags/threads/ThreadTag.java

ViolationLine
The class 'ThreadTag' has a Cyclomatic Complexity of 2 (Highest = 11). 38
Private field could be made final. It is only initialized in the declaration or constructor. 60
The method 'doTag' has a Cyclomatic Complexity of 11. 72
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 118
Avoid if (x != y) ..; else ..; 132
Avoid if (x != y) ..; else ..; 150

org/apache/commons/jelly/tags/threads/UseThreadTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 46
Avoid if (x != y) ..; else ..; 48
Avoid if (x != y) ..; else ..; 57
Avoid if (x != y) ..; else ..; 62

org/apache/commons/jelly/tags/threads/WaitForTag.java

ViolationLine
Deeply nested if..then statements are hard to read 84
These nested if statements could be combined 84
Deeply nested if..then statements are hard to read 96
These nested if statements could be combined 96

org/apache/commons/jelly/threads/TestJelly.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 38