PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
1340

Files

FilesViolations
javax/servlet/jsp/jstl/sql/ResultImpl.java 6
javax/servlet/jsp/jstl/sql/ResultSupport.java 1
org/apache/commons/jelly/tags/sql/DataSourceUtil.java 6
org/apache/commons/jelly/tags/sql/DataSourceWrapper.java 5
org/apache/commons/jelly/tags/sql/DriverTag.java 1
org/apache/commons/jelly/tags/sql/ParamTag.java 1
org/apache/commons/jelly/tags/sql/QueryTag.java 4
org/apache/commons/jelly/tags/sql/ResultImpl.java 6
org/apache/commons/jelly/tags/sql/SetDataSourceTag.java 3
org/apache/commons/jelly/tags/sql/SqlTagSupport.java 2
org/apache/commons/jelly/tags/sql/TransactionTag.java 3
org/apache/commons/jelly/tags/sql/UpdateTag.java 1
org/apache/commons/jelly/tags/sql/TestJUnit.java 1

javax/servlet/jsp/jstl/sql/ResultImpl.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 35
Private field could be made final. It is only initialized in the declaration or constructor. 36
Private field could be made final. It is only initialized in the declaration or constructor. 37
Private field could be made final. It is only initialized in the declaration or constructor. 38
This call to Collection.toArray() may be optimizable 111
This call to Collection.toArray() may be optimizable 128

javax/servlet/jsp/jstl/sql/ResultSupport.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 64

org/apache/commons/jelly/tags/sql/DataSourceUtil.java

ViolationLine
Avoid unused private fields such as 'log' 45
Avoid reassigning parameters such as 'rawDataSource' 53
Avoid unused private methods such as 'getDataSource' 94
These nested if statements could be combined 105
Avoid if (x != y) ..; else ..; 113
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 143

org/apache/commons/jelly/tags/sql/DataSourceWrapper.java

ViolationLine
Avoid unused private fields such as 'driverClassName' 42
Ensure that Connection objects are always closed after use 75
Avoid if (x != y) ..; else ..; 76
The String literal "NOT_SUPPORTED" appears 5 times in this file; the first occurrence is on line 104 104
Use block level rather than method level synchronization 131

org/apache/commons/jelly/tags/sql/DriverTag.java

ViolationLine
Avoid unused private fields such as 'scope' 38

org/apache/commons/jelly/tags/sql/ParamTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 51

org/apache/commons/jelly/tags/sql/QueryTag.java

ViolationLine
The class 'QueryTag' has a Cyclomatic Complexity of 4 (Highest = 13). 41
Avoid really long methods. 102
The method 'doTag' has a Cyclomatic Complexity of 13. 102
Avoid if (x != y) ..; else ..; 140

org/apache/commons/jelly/tags/sql/ResultImpl.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor. 37
Private field could be made final. It is only initialized in the declaration or constructor. 38
Private field could be made final. It is only initialized in the declaration or constructor. 39
Private field could be made final. It is only initialized in the declaration or constructor. 40
This call to Collection.toArray() may be optimizable 159
This call to Collection.toArray() may be optimizable 176

org/apache/commons/jelly/tags/sql/SetDataSourceTag.java

ViolationLine
Avoid unused private fields such as 'scope' 47
Avoid if (x != y) ..; else ..; 99
Avoid if (x != y) ..; else ..; 125

org/apache/commons/jelly/tags/sql/SqlTagSupport.java

ViolationLine
Ensure that Connection objects are always closed after use 136
Avoid if (x != y) ..; else ..; 141

org/apache/commons/jelly/tags/sql/TransactionTag.java

ViolationLine
Avoid unused local variables such as 'finished' 107
Avoid empty catch blocks 117
Avoid empty catch blocks 188

org/apache/commons/jelly/tags/sql/UpdateTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 82

org/apache/commons/jelly/tags/sql/TestJUnit.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 38