PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
722

Files

FilesViolations
org/apache/commons/jelly/tags/util/AvailableTag.java 2
org/apache/commons/jelly/tags/util/FileTag.java 1
org/apache/commons/jelly/tags/util/LoadTextTag.java 3
org/apache/commons/jelly/tags/util/PropertiesTag.java 3
org/apache/commons/jelly/tags/util/ReplaceTag.java 3
org/apache/commons/jelly/tags/util/Customer.java 9
org/apache/commons/jelly/tags/util/TestJelly.java 1

org/apache/commons/jelly/tags/util/AvailableTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 50
Avoid unused local variables such as 'fileName' 56

org/apache/commons/jelly/tags/util/FileTag.java

ViolationLine
Avoid unused local variables such as 'available' 43

org/apache/commons/jelly/tags/util/LoadTextTag.java

ViolationLine
Avoid unused imports such as 'java.io.FileReader' 21
Avoid if (x != y) ..; else ..; 67
Avoid if (x != y) ..; else ..; 86

org/apache/commons/jelly/tags/util/PropertiesTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 53
An empty statement (semicolon) not part of a loop 83
Avoid if (x != y) ..; else ..; 88

org/apache/commons/jelly/tags/util/ReplaceTag.java

ViolationLine
Avoid unused private fields such as 'log' 39
Avoid if (x != y) ..; else ..; 81
Avoid if (x != y) ..; else ..; 90

org/apache/commons/jelly/tags/util/Customer.java

ViolationLine
Avoid unused imports such as 'java.util.ArrayList' 18
Avoid unused imports such as 'java.util.Iterator' 19
Avoid unused imports such as 'java.util.List' 20
Overridable method 'setName' called during construction 39
Overridable method 'setName' called during construction 43
Overridable method 'setCity' called during construction 44
Overridable method 'setName' called during construction 48
Overridable method 'setCity' called during construction 49
Overridable method 'setLocation' called during construction 50

org/apache/commons/jelly/tags/util/TestJelly.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 38