Apache Commons logo Commons BCEL

Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag Class Total number of occurrences Tag strings used by tag class
@todo 0 @todo
FIXME 33 FIXME
TODO 154 TODO

Each tag is detailed below:

FIXME

Number of occurrences found in the code: 33

org.apache.bcel.generic.ElementValueGen Line
--No comment-- 118
org.apache.bcel.verifier.VerifierAppFrame Line
report the error using the GUI 117
handle the error 244
handle the error 273
org.apache.bcel.verifier.VerifyDialog Line
report the error 535
org.apache.bcel.verifier.statics.Pass1Verifier Line
currently, Pass1Verifier treats jc == null as a special case, so we don't need to do anything here. A better solution would be to simply throw the ClassNotFoundException out of this method. 167
org.apache.bcel.verifier.statics.Pass2Verifier Line
this might not be the best way to handle missing classes. 322
this might not be the best way to handle missing classes. 551
this might not be the best way to handle missing classes. 1277
this might not be the best way to handle missing classes. 1319
this might not be the best way to handle missing classes. 1367
this might not be the best way to handle missing classes. 1389
this might not be the best way to handle missing classes. 1435
org.apache.bcel.verifier.statics.Pass3aVerifier Line
maybe not the best way to handle this 225
maybe not the best way to handle this 335
maybe not the best way to handle this 383
maybe not the best way to handle this 523
maybe not the best way to handle this 576
maybe not the best way to handle this 601
maybe not the best way to handle this throw new AssertionViolatedException("Missing class: " + e, e); 631
maybe not the best way to handle this 837
maybe not the best way to handle this 1065
maybe not the best way to handle this 1186
org.apache.bcel.verifier.structurals.InstConstraintVisitor Line
maybe not the best way to handle this 336
maybe not the best way to handle this 1083
maybe not the best way to handle this 1729
maybe not the best way to handle this 1743
maybe not the best way to handle this 1781
maybe not the best way to handle this 2453
maybe not the best way to handle this 2466
org.apache.bcel.verifier.structurals.LocalVariables Line
maybe not the best way to handle this 183
org.apache.bcel.verifier.structurals.OperandStack Line
maybe not the best way to handle this 165
org.apache.bcel.verifier.structurals.Pass3bVerifier Line
maybe not the best way to handle this 340

TODO

Number of occurrences found in the code: 154

org.apache.bcel.Constants Line
mutable public array!! 2422
org.apache.bcel.PLSETest Line
need for real assertions here 155
org.apache.bcel.classfile.AccessFlags Line
not used externally at present 34
org.apache.bcel.classfile.AnnotationEntry Line
return List 125
org.apache.bcel.classfile.Annotations Line
Auto-generated method stub 91
org.apache.bcel.classfile.Attribute Line
make private (has getter & setter) 249
org.apache.bcel.classfile.BootstrapMethod Line
should this throw? 92
org.apache.bcel.classfile.BootstrapMethods Line
this could be made final (setter is not used) 39
org.apache.bcel.classfile.Code Line
this could be made final (setter is not used) 64
this could be made final (setter is not used) 65
org.apache.bcel.classfile.CodeException Line
should this throw? 131
unused 194
unused 201
org.apache.bcel.classfile.Constant Line
should be private & final 126
should this throw? 157
org.apache.bcel.classfile.ConstantCP Line
make private (has getter & setter) This field has the same meaning for all subclasses. 46
make private (has getter & setter) 53
org.apache.bcel.classfile.ConstantPool Line
should this throw? 223
org.apache.bcel.classfile.ConstantUtf8 Line
these should perhaps be AtomicInt? 87
org.apache.bcel.classfile.ElementValue Line
isRuntimeVisible 114
should be final 139
should be final 144
org.apache.bcel.classfile.InnerClass Line
should this throw? 90
unused 153
unused 160
org.apache.bcel.classfile.InnerClasses Line
this could be recoded to use a lower level constructor after creating a copy of the inner classes 102
org.apache.bcel.classfile.JavaClass Line
Check if assignment compatibility is sufficient. What does Sun do? 423
make protected? 872
org.apache.bcel.classfile.LineNumber Line
should this throw? 89
org.apache.bcel.classfile.LineNumberTable Line
could use the lower level constructor and thereby allow lineNumberTable to be made final 102
org.apache.bcel.classfile.LocalVariable Line
should this throw? 137
unused 230
unused 244
unused 251
unused 258
org.apache.bcel.classfile.MethodParameter Line
should this throw? 73
org.apache.bcel.classfile.ModuleExports Line
should this throw? 80
org.apache.bcel.classfile.ModuleOpens Line
should this throw? 80
org.apache.bcel.classfile.ModuleProvides Line
should this throw? 82
org.apache.bcel.classfile.ModuleRequires Line
should this throw? 71
org.apache.bcel.classfile.ParameterAnnotationEntry Line
isRuntimeVisible 67
org.apache.bcel.classfile.StackMapEntry Line
unused 335
unused 343
org.apache.bcel.classfile.StackMapType Line
should this throw? 92
org.apache.bcel.generic.BranchHandle Line
could be package-protected? 67
org.apache.bcel.generic.CPInstruction Line
could be package-protected? 109
org.apache.bcel.generic.ClassGen Line
Sometime later, trash any attributes called 'RuntimeVisibleAnnotations' or 'RuntimeInvisibleAnnotations' 346
could be package-protected - only called by test code 492
could be package-protected - only called by test code 512
org.apache.bcel.generic.CodeExceptionGen Line
could be package-protected? 125
could be package-protected? 135
could be package-protected? 145
org.apache.bcel.generic.ConstantPoolGen Line
should this be handled somehow? } else if (c instanceof org.apache.bcel.classfile.ConstantMethodHandle) { 203
should this be handled somehow? } else if (c instanceof org.apache.bcel.classfile.ConstantModule) { 205
should this be handled somehow? } else if (c instanceof org.apache.bcel.classfile.ConstantPackage) { 207
should this be handled somehow? } else { // Not helpful, should throw an exception. assert false : "Unexpected constant type: " + c.getClass().getName(); } 209
org.apache.bcel.generic.ElementValueGen Line
isRuntimeVisible ?????????? 117
org.apache.bcel.generic.FieldAnnotationsTest Line
L...;? 68
org.apache.bcel.generic.FieldGenOrMethodGen Line
could this be package protected? 63
could be package-protected? 160
could be package-protected? 165
could be package-protected? 170
org.apache.bcel.generic.GeneratingAnnotatedClassesTest Line
L??; 358
org.apache.bcel.generic.Instruction Line
check range? 559
org.apache.bcel.generic.InstructionHandle Line
remove this method in any redesign of BCEL 268
org.apache.bcel.generic.InstructionList Line
could be package-protected? (some test code would need to be repackaged) 1072
should this be an error? 1135
org.apache.bcel.generic.JavaHome Line
Apache Commons 2.14.0: Use FilesUncheck 73
org.apache.bcel.generic.LDC Line
useless check? 71
org.apache.bcel.generic.LineNumberGen Line
could be package-protected? 84
could be package-protected? 90
org.apache.bcel.generic.LocalVariableGen Line
could be package-protected? 182
could be package-protected? 200
org.apache.bcel.generic.LocalVariableInstruction Line
could be package-protected? 167
org.apache.bcel.generic.MethodGen Line
could be package-protected? 1046
could be package-protected? 1050
could be package-protected? (some tests would need repackaging) 1057
could be package-protected? (some tests would need repackaging) 1088
could be package-protected? 1099
org.apache.bcel.generic.ReferenceType Line
Above sounds a little arbitrary. On the other hand, there is no object referenced by {@link #NULL} so we can also say all the objects referenced by {@link #NULL} were derived from {@link Object}. However, the Java Language's "instanceof" operator proves us wrong: "null" is not referring to an instance of {@link Object} :) 60
Is there a proof of {@link #OBJECT} being the direct ancestor of every ArrayType? 67
Above sounds a little arbitrary. On the other hand, there is no object referenced by {@link #NULL} so we can also say all the objects referenced by {@link #NULL} were derived from {@link Object}. However, the Java Language's "instanceof" operator proves us wrong: "null" is not referring to an instance of {@link Object} :) 91
Is there a proof of {@link #OBJECT} being the direct ancestor of every ArrayType? 108
The above line is correct comparing to the vmspec2. But one could make class file verification a bit stronger here by using the notion of superinterfaces or even castability or assignment compatibility. 117
Check if this is still valid or find a way to dynamically find out which interfaces arrays implement. However, as of the JVM specification edition 2, there are at least two different pages where assignment compatibility is defined and on one of them "interfaces implemented by arrays" is exchanged with "'Cloneable' or 'java.io.Serializable'" 229
org.apache.bcel.generic.Select Line
could be package-protected? 291
org.apache.bcel.generic.Type Line
should be final (and private) 323
org.apache.bcel.util.BCELifierTest Line
detect if JDK present and skip test if not 227
org.apache.bcel.util.Class2HTMLTest Line
assertions on generated HTML code 52
org.apache.bcel.util.ClassQueue Line
not used externally 34
org.apache.bcel.verifier.statics.Pass1Verifier Line
Maybe change Repository's behavior to throw a LoadingException instead of just returning "null" if a class file cannot be found or in another way be looked up. 153
org.apache.bcel.verifier.statics.Pass2Verifier Line
rework it. 226
implement. Are there any restrictions? 1176
org.apache.bcel.verifier.statics.Pass3aVerifier Line
From time to time check if BCEL allows to detect if the 'count' operand is consistent with the information in the CONSTANT_InterfaceMethodref and if the last operand is zero. By now, BCEL hides those two operands because they're superfluous. 457
Make this a binary search! The instructionPositions array is naturally ordered! 924
--No comment-- 1027
Check how BCEL handles (and will handle) instructions like IMPDEP1, IMPDEP2, BREAKPOINT... that BCEL knows about but which are illegal anyway. We currently go the safe way here. 1105
see the do_verify() comments. Maybe we should really work on the byte array first to give more comprehensive messages. 1148
Review Exception API, possibly build in some "offending instruction" thing when we're ready to insulate the offending instruction by doing the above thing. 1150
Implement as much as possible here. BCEL does _not_ check everything. 1154
org.apache.bcel.verifier.structurals.ControlFlowGraph Line
implement caching! 97
remove. Only JustIce must not use it, but foreign users of the ControlFlowGraph will want it. Thanks Johannes Wust. throw new AssertionViolatedException("DID YOU REALLY WANT TO ASK FOR RET'S SUCCS?"); 110
Can be performance-improved. 319
Put information in the brackets, for example Is this an ExceptionHandler? Is this a RET? Is this the start of a subroutine? 344
org.apache.bcel.verifier.structurals.ExecutionVisitor Line
could be package-protected? 93
could be package-protected? 103
One could use a sophisticated analysis here to check if a type cannot possibly be cated to another and by so doing predict the ClassCastException at run-time. 234
org.apache.bcel.verifier.structurals.InstConstraintVisitor Line
could be package-protected? 153
could be package-protected? 164
This can possibly only be checked using Staerk-et-al's "set-of-object types", not using "wider cast object types" created during verification. Comment it out if you encounter problems. See also the analogon at visitPUTFIELD|visitPUTSTATIC. 939
One day move to Staerk-et-al's "Set of object types" instead of "wider" object types created during the verification. "Wider" object types don't allow us to check for things like that below. constraintViolated(o, "The referenced field has the ACC_PROTECTED modifier, "+ "and it's a member of the current class or a superclass of the current class."+ " However, the referenced object type '"+stack().peek()+ "' is not the current class or a subclass of the current class."); } 1066
Could go into Pass 3a. 1077
--No comment-- 1550
Do we want to do anything with it? ConstantInterfaceMethodref cimr = (ConstantInterfaceMethodref) (cpg.getConstant(o.getIndex())); 1565
This can only be checked when using Staerk-et-al's "set of object types" instead of a "wider cast object type" created during verification. if ( ! rFromStack.isAssignmentCompatibleWith(rFromDesc) ) { constraintViolated(o, "Expecting a '"+fromDesc+"' but found a '"+fromStack+ "' on the stack (which is not assignment compatible)."); } 1593
This can only be checked if we're using Staerk-et-al's "set of object types" instead of "wider cast object types" generated during verification. if ( ! Repository.implementationOf(objRefClassName, theInterface) ) { constraintViolated(o, "The 'objRef' item '" + objRef + "' does not implement '" + theInterface + "' as expected."); } 1624
This can possibly only be checked when using Staerk-et-al's "set of object types" instead of a single "wider cast object type" created during verification. 1663
Could go into Pass 3a. 2447
This can only be checked if using Staerk-et-al's "set of object types" instead of a "wider cast object type" created during verification. if (! (objectref.isAssignmentCompatibleWith(mg.getType())) ) { constraintViolated(o, "Type on stack top which should be returned is a '"+stack().peek()+ "' which is not assignment compatible with the return type of this method, '"+mg.getType()+"'."); } 2524
org.apache.bcel.verifier.structurals.LocalVariables Line
if ((locals[i] instanceof org.apache.bcel.generic.ReturnaddressType) && (lv.locals[i] instanceof org.apache.bcel.generic.ReturnaddressType)) { //System.err.println("merging "+locals[i]+" and "+lv.locals[i]); throw new AssertionViolatedException("Merging different ReturnAddresses: '"+locals[i]+"' and '"+lv.locals[i]+"'."); } 176
could be package-protected? 194
org.apache.bcel.verifier.structurals.Pass3bVerifier Line
Throughout pass 3b, upper halves of LONG and DOUBLE are represented by Type.UNKNOWN. This should be changed in favor of LONG_Upper and DOUBLE_Upper as in pass 2. 59
the "oldchain" and "newchain" is used to determine the subroutine we're in (by searching for the last JSR) by the InstructionContext implementation. Therefore, we should not use this chain mechanism when dealing with exception handlers. Example: a JSR with an exception handler as its successor does not mean we're in a subroutine if we go to the exception handler. We should address this problem later; by now we simply "cut" the chain by using an empty chain for the exception handlers. if (v.execute(new Frame(u.getOutFrame(oldchain).getLocals(), new OperandStack (u.getOutFrame().getStack().maxStack(), (exc_hds[s].getExceptionType() == null ? Type.THROWABLE : exc_hds[s].getExceptionType())) ), newchain), icv, ev) { icq.add(v, (ArrayList) newchain.clone()); 251
This is buggy, we check only the top-level return instructions this way. Maybe some maniac returns from a method when in a subroutine? 275
org.apache.bcel.verifier.structurals.Subroutines Line
refer to the paper. 56
Implement caching. 148
can this be made private? CHECKSTYLE:ON 400
org.apache.bcel.verifier.tests.TestArrayAccess02Creator Line
why is this not used 64
why is this not used 67
why is this not used 80
why is this not used 84
why is this not used 88
why is this not used 95
org.apache.bcel.verifier.tests.TestArrayAccess03Creator Line
why is this not used 64
why is this not used 67
why is this not used 80
why is this not used 84
why is this not used 91
org.apache.bcel.verifier.tests.TestArrayAccess04Creator Line
why is this not used 68
why is this not used 71
why is this not used 84
why is this not used 88
why is this not used 91
why is this not used 96
org.apache.bcel.verifier.tests.TestReturn01Creator Line
why is this not used 60
why is this not used 63
why is this not used 76
why is this not used 81
org.apache.bcel.verifier.tests.TestReturn03Creator Line
why is this not used 66
why is this not used 69
why is this not used 82
org.apache.bcel.visitors.CountingVisitor Line
Auto-generated method stub 301
Auto-generated method stub 312
Auto-generated method stub 491