Apache Commons logo Commons Lang

Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag Class Total number of occurrences Tag strings used by tag class
Needs Work 49 TODO, FIXME, XXX
Noteable Markers 17 NOTE, NOPMD, NOSONAR

Each tag is detailed below:

Needs Work

Number of occurrences found in the code: 49

org.apache.commons.lang3.ArraySorter Line
For 4.0, rename to ArraySort, since we cover the sort() method here, see also ArrayFill. 25
org.apache.commons.lang3.CharRange Line
This is no longer public and will be removed later as CharSet is moved to depend on Range. 32
org.apache.commons.lang3.CharSequenceUtils Line
Do we assume searchChar is usually relatively small; // If so then calling toString() on it is better than reverting to // the green implementation in the else block return ((String) cs).indexOf((String) searchChar, start); } else { 61
Implement rather than convert to String return cs.toString().indexOf(searchChar.toString(), start); } 66
org.apache.commons.lang3.ClassLoaderUtilsTest Line
How to better test considering this test may be called from an IDE and Maven? 37
How to better test considering this test may be called from an IDE and Maven? 43
org.apache.commons.lang3.LocaleUtils Line
Should this return the default locale? 316
org.apache.commons.lang3.ObjectUtils Line
Rename to getIfNull in 4.0 595
Java 11 Use Optional#isEmpty() 1031
org.apache.commons.lang3.RandomUtilsTest Line
should be <max? 71
should be <max? 80
org.apache.commons.lang3.StringEscapeUtils Line
Create a parent class - 'SinglePassTranslator' ? It would handle the index checking + length returning, and could also have an optimization check method. 48
throw "illegal character: \92" as an Exception if a \ on the end of the Java (as per the compiler)? 321
org.apache.commons.lang3.StringEscapeUtilsTest Line
I think this should hold, needs further investigation String unescapedFromEntity = StringEscapeUtils.unescapeHtml4( "𝍢" ); assertEquals( "High Unicode should have been unescaped", original, unescapedFromEntity); 208
refine API for escaping/unescaping specific HTML versions 218
org.apache.commons.lang3.Validate Line
when breaking BC, consider returning value 94
when breaking BC, consider returning value 115
when breaking BC, consider returning value 135
when breaking BC, consider returning value 156
when breaking BC, consider returning value 177
when breaking BC, consider returning value 201
when breaking BC, consider returning value 273
when breaking BC, consider returning value 294
when breaking BC, consider returning value 314
when breaking BC, consider returning value 335
when breaking BC, consider returning value 356
when breaking BC, consider returning value 380
when breaking BC, consider returning type 402
when breaking BC, consider returning type 427
when breaking BC, consider returning obj 449
when breaking BC, consider returning obj 472
when breaking BC, consider returning input 591
when breaking BC, consider returning input 614
org.apache.commons.lang3.exception.ExceptionUtils Line
Remove in Lang 4 48
Remove in Lang 4 236
org.apache.commons.lang3.reflect.FieldUtils Line
is this workaround still needed? lang requires Java 6 Sun Java 1.3 has a bugged implementation of getField hence we write the code ourselves 173
org.apache.commons.lang3.reflect.MemberUtils Line
extract an interface to implement compareParameterSets(...)? 34
org.apache.commons.lang3.reflect.TypeUtilsTest Line
Is this correct? 438
Is this correct? 440
This test returns true unlike the test above. Is this a bug in this test or in the main code? 950
org.apache.commons.lang3.text.StrBuilder Line
make private? 270
make private? 273
org.apache.commons.lang3.text.translate.NumericEntityUnescaper Line
?: Create an OptionsSet class to hide some of the conditional logic below 58
org.apache.commons.lang3.text.translate.UnicodeEscaper Line
Handle potential + sign per various Unicode escape implementations 128
org.apache.commons.lang3.time.AbstractFormatCache Line
Before making public move from getDateTimeInstance(Integer, ...) to int; or some other approach. 38
org.apache.commons.lang3.time.DurationFormatUtils Line
Compare performance to see if anything was lost by losing this optimisation. 515
Need to handle escaping of ' 675
org.apache.commons.lang3.time.DurationUtils Line
when using Java >= 9: Use TimeUnit.toChronoUnit(). 159
org.apache.commons.lang3.time.FastDateParser Line
Use of getZoneStrings() is discouraged per its Javadoc. 523

Noteable Markers

Number of occurrences found in the code: 17

org.apache.commons.lang3.CharSequenceUtils Line
- we must do a forward traversal for this to avoid duplicating code points 265
org.apache.commons.lang3.CharSet Line
This is no longer public as CharRange is no longer a public class. It may be replaced when CharSet moves to Range. 256
org.apache.commons.lang3.ClassUtils Line
From v2.2, this method handles {@code Void.TYPE}, returning {@code Void.TYPE}. </p> 1475
org.apache.commons.lang3.StringUtils Line
LINT this intentionally uses == to allow for both null 867
LINT this intentionally uses == to allow for both null 960
logic duplicated below START 6674
logic mostly below END 6689
logic mostly duplicated above START 6728
logic duplicated above END 6743
LINT str cannot be null here 8354
org.apache.commons.lang3.builder.EqualsBuilder Line
we cannot store the actual objects in a HashSet, as that would use the very hashCode() we are in the process of calculating. 99
org.apache.commons.lang3.builder.HashCodeBuilder Line
we cannot store the actual objects in a HashSet, as that would use the very hashCode() we are in the process of calculating. 124
This method uses >> and not >>> as Effective Java and Long.hashCode do. Ideally we should switch to >>> at some stage. There are backwards compat issues, so that will have to wait for the time being. cf LANG-342. 738
org.apache.commons.lang3.reflect.TypeUtilsTest Line
cast is required by Sun Java, but not by Eclipse 698
org.apache.commons.lang3.text.ExtendedMessageFormatTest Line
FAILING - currently sub-formats not supported 138
FAILING - currently sub-formats not supported 155
org.apache.commons.lang3.time.StopWatch Line
As from v2.1, the methods protect against inappropriate calls. Thus you cannot now call stop before start, resume before suspend or unsplit before split. </p> 45