Apache Commons logo Commons Lang

Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag Class Total number of occurrences Tag strings used by tag class
Needs Work 71 TODO, FIXME, XXX
Noteable Markers 27 NOTE, NOPMD, NOSONAR

Each tag is detailed below:

Needs Work

Number of occurrences found in the code: 71

org.apache.commons.lang3.AbstractLangTest Line
Do more to make sure memory is not retained, maybe like Log4j checks for it. 36
org.apache.commons.lang3.ArraySorter Line
For 4.0, rename to ArraySort, since we cover the sort() method here, see also ArrayFill. 25
org.apache.commons.lang3.CharRange Line
This is no longer public and will be removed later as CharSet is moved to depend on Range. 41
org.apache.commons.lang3.ClassLoaderUtilsTest Line
How to better test considering this test may be called from an IDE and Maven? 36
How to better test considering this test may be called from an IDE and Maven? 42
org.apache.commons.lang3.Functions Line
for 4.0: Move to org.apache.commons.lang3.function. </p> 82
for 4.0: Move to org.apache.commons.lang3.function. </p> 108
for 4.0: Move to org.apache.commons.lang3.function. </p> 136
for 4.0: Move to org.apache.commons.lang3.function. </p> 163
for 4.0: Move to org.apache.commons.lang3.function. </p> 187
for 4.0: Move to org.apache.commons.lang3.function. </p> 211
for 4.0: Move to org.apache.commons.lang3.function. </p> 237
for 4.0: Move to org.apache.commons.lang3.function. </p> 262
for 4.0: Move to org.apache.commons.lang3.function. </p> 284
org.apache.commons.lang3.LocaleUtils Line
Should this return the default locale? 432
org.apache.commons.lang3.ObjectUtils Line
Move to ComparableUtils. </p> 285
Move to ComparableUtils. </p> 300
Java 11 Use Optional#isEmpty() 975
Move to ComparableUtils. </p> 1017
Move to ComparableUtils. </p> 1087
org.apache.commons.lang3.RandomUtilsTest Line
should be <max? 73
should be <max? 80
should be <max? 89
should be <max? 99
org.apache.commons.lang3.StringEscapeUtils Line
throw "illegal character: \92" as an Exception if a \ on the end of the Java (as per the compiler)? 317
org.apache.commons.lang3.StringEscapeUtilsTest Line
I think this should hold, needs further investigation String unescapedFromEntity = StringEscapeUtils.unescapeHtml4("𝍢"); assertEquals("High Unicode should have been unescaped", original, unescapedFromEntity); 252
refine API for escaping/unescaping specific HTML versions 261
org.apache.commons.lang3.Validate Line
when breaking BC, consider returning value 98
when breaking BC, consider returning value 119
when breaking BC, consider returning value 139
when breaking BC, consider returning value 160
when breaking BC, consider returning value 181
when breaking BC, consider returning value 205
when breaking BC, consider returning value 277
when breaking BC, consider returning value 298
when breaking BC, consider returning value 318
when breaking BC, consider returning value 339
when breaking BC, consider returning value 360
when breaking BC, consider returning value 384
when breaking BC, consider returning type 410
when breaking BC, consider returning type 439
when breaking BC, consider returning obj 465
when breaking BC, consider returning obj 487
when breaking BC, consider returning input 632
when breaking BC, consider returning input 657
org.apache.commons.lang3.builder.EqualsBuilderReflectJreImplementationNoForceTest Line
Override failing methods with new assertions 27
org.apache.commons.lang3.builder.JsonToStringStyleNoForceTest Line
Override failing methods with new assertions 27
org.apache.commons.lang3.builder.MultilineRecursiveToStringStyleNoForceTest Line
Override failing methods with new assertions 27
org.apache.commons.lang3.builder.ReflectionToStringBuilderExcludeNoForceTest Line
Override failing methods with new assertions 27
org.apache.commons.lang3.builder.ReflectionToStringBuilderExcludeNullValuesNoForceTest Line
Override failing methods with new assertions 27
org.apache.commons.lang3.builder.ReflectionToStringBuilderExcludeWithAnnotationNoForceTest Line
Override failing methods with new assertions 27
org.apache.commons.lang3.builder.ReflectionToStringBuilderIncludeNoForceTest Line
Override failing methods with new assertions 27
org.apache.commons.lang3.builder.ReflectionToStringBuilderSummaryNoForceTest Line
Override failing methods with new assertions 27
org.apache.commons.lang3.builder.ToStringBuilderNoForceTest Line
Override failing methods with new assertions 27
org.apache.commons.lang3.exception.ExceptionUtils Line
Remove in Lang 4 51
Remove in Lang 4 257
org.apache.commons.lang3.reflect.FieldUtils Line
is this workaround still needed? lang requires Java 6 Sun Java 1.3 has a bugged implementation of getField hence we write the code ourselves 181
org.apache.commons.lang3.reflect.MemberUtils Line
extract an interface to implement compareParameterSets(...)? 32
org.apache.commons.lang3.reflect.TypeUtilsTest Line
Is this correct? 795
Is this correct? 797
This test returns true unlike the test above. Is this a bug in this test or in the main code? 1060
org.apache.commons.lang3.text.StrBuilder Line
make private? 277
make private? 280
org.apache.commons.lang3.text.translate.NumericEntityUnescaper Line
?: Create an OptionsSet class to hide some of the conditional logic below 66
org.apache.commons.lang3.text.translate.UnicodeEscaper Line
Handle potential + sign per various Unicode escape implementations 134
org.apache.commons.lang3.time.AbstractFormatCache Line
Before making public move from getDateTimeInstance(Integer, ...) to int; or some other approach. 37
org.apache.commons.lang3.time.DurationFormatUtils Line
Compare performance to see if anything was lost by losing this optimization. 530
org.apache.commons.lang3.time.DurationUtils Line
when using Java >= 9: Use TimeUnit.toChronoUnit(). 205
org.apache.commons.lang3.time.FastDateParser Line
Use of getZoneStrings() is discouraged per its Javadoc. 570
org.apache.commons.lang3.time.FastDateParser_TimeZoneStrategyTest Line
Why don't all short IDs parse, even on Java 8? 92
Why don't all short IDs parse, even on Java 8? 111

Noteable Markers

Number of occurrences found in the code: 27

org.apache.commons.lang3.BooleanUtils Line
This returns {@code null} and will throw a {@link NullPointerException} if unboxed to a boolean. </p> 255
This method may return {@code null} and may throw a {@link NullPointerException} if unboxed to a {@code boolean}. </p> 603
This method may return {@code null} and may throw a {@link NullPointerException} if unboxed to a {@code boolean}. </p> 650
This method may return {@code null} and may throw a {@link NullPointerException} if unboxed to a {@code boolean}. </p> 675
This method may return {@code null} and may throw a {@link NullPointerException} if unboxed to a {@code boolean}. </p> 733
This method may return {@code null} and may throw a {@link NullPointerException} if unboxed to a {@code boolean}. </p> 858
org.apache.commons.lang3.CharSequenceUtils Line
- we must do a forward traversal for this to avoid duplicating code points 298
org.apache.commons.lang3.ClassUtils Line
From v2.2, this method handles {@code Void.TYPE}, returning {@code Void.TYPE}. </p> 1676
org.apache.commons.lang3.StringUtils Line
This method changed in 2.0. It now more closely matches Perl chomp. </p> 702
This method changed in version 2.0. It now more closely matches Perl chomp. For the previous behavior, use {@link #substringBeforeLast(String, String)}. This method uses {@link String#endsWith(String)}. </p> 749
LINT this intentionally uses == to allow for both null 906
LINT this intentionally uses == to allow for both null 1007
This method changed in Lang version 2.0. It no longer trims the CharSequence. That functionality is available in isBlank(). </p> 3613
logic duplicated below START 6564
logic mostly below END 6579
logic mostly duplicated above START 6618
logic duplicated above END 6633
LINT str cannot be null here 8246
This method changed in Lang version 2.0. It no longer performs a word based algorithm. If you only use ASCII, you will notice no change. That functionality is available in org.apache.commons.lang3.text.WordUtils. </p> 8769
org.apache.commons.lang3.builder.EqualsBuilder Line
we cannot store the actual objects in a HashSet, as that would use the very hashCode() we are in the process of calculating. 142
org.apache.commons.lang3.builder.HashCodeBuilder Line
we cannot store the actual objects in a HashSet, as that would use the very hashCode() we are in the process of calculating. 191
This method uses >> and not >>> as Effective Java and Long.hashCode do. Ideally we should switch to >>> at some stage. There are backwards compat issues, so that will have to wait for the time being. See LANG-342. 817
org.apache.commons.lang3.builder.ToStringStyle Line
It assumes that the toString has been created from the same ToStringStyle. </p> 1803
It assumes that the toString has been created from the same ToStringStyle. </p> 1821
org.apache.commons.lang3.text.ExtendedMessageFormatTest Line
FAILING - currently sub-formats not supported 146
FAILING - currently sub-formats not supported 163
org.apache.commons.lang3.time.StopWatch Line
As from v2.1, the methods protect against inappropriate calls. Thus you cannot now call stop before start, resume before suspend or unsplit before split. </p> 55