Apache Commons logo Commons Imaging™ logo

PMD Results

The following document contains the results of PMD 5.2.1.

Files

org/apache/commons/imaging/ColorTools.java

Violation Line
Each class should declare at least one constructor 42248

org/apache/commons/imaging/FormatCompliance.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 92
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 139

org/apache/commons/imaging/ImageDump.java

Violation Line
Each class should declare at least one constructor 3199

org/apache/commons/imaging/ImageParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 190
Consider using varargs for methods or constructors which take an array the last parameter. 412
Consider using varargs for methods or constructors which take an array the last parameter. 469
Consider using varargs for methods or constructors which take an array the last parameter. 596
Consider using varargs for methods or constructors which take an array the last parameter. 700
Consider using varargs for methods or constructors which take an array the last parameter. 794

org/apache/commons/imaging/Imaging.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 201
Consider using varargs for methods or constructors which take an array the last parameter. 226
Consider using varargs for methods or constructors which take an array the last parameter. 365
Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 455472
Consider using varargs for methods or constructors which take an array the last parameter. 488
Consider using varargs for methods or constructors which take an array the last parameter. 600
Consider using varargs for methods or constructors which take an array the last parameter. 663
Consider using varargs for methods or constructors which take an array the last parameter. 804
Consider using varargs for methods or constructors which take an array the last parameter. 899
Consider using varargs for methods or constructors which take an array the last parameter. 982
Consider using varargs for methods or constructors which take an array the last parameter. 1130
Consider using varargs for methods or constructors which take an array the last parameter. 1168
Consider using varargs for methods or constructors which take an array the last parameter. 1222
Consider using varargs for methods or constructors which take an array the last parameter. 1319

org/apache/commons/imaging/color/ColorCmyk.java

Violation Line
Avoid using if statements without curly braces 131

org/apache/commons/imaging/common/BinaryConstant.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 26
Consider using varargs for methods or constructors which take an array the last parameter. 47

org/apache/commons/imaging/common/BinaryFunctions.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 36
Consider using varargs for methods or constructors which take an array the last parameter. 269

org/apache/commons/imaging/common/BinaryOutputStream.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 62

org/apache/commons/imaging/common/GenericImageMetadata.java

Violation Line
Each class should declare at least one constructor 2298

org/apache/commons/imaging/common/PackBits.java

Violation Line
Each class should declare at least one constructor 25163
Consider using varargs for methods or constructors which take an array the last parameter. 108

org/apache/commons/imaging/common/RgbBufferedImageFactory.java

Violation Line
Each class should declare at least one constructor 2236

org/apache/commons/imaging/common/SimpleBufferedImageFactory.java

Violation Line
Each class should declare at least one constructor 2239

org/apache/commons/imaging/common/bytesource/ByteSourceArray.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 26
Consider using varargs for methods or constructors which take an array the last parameter. 31

org/apache/commons/imaging/common/bytesource/ByteSourceInputStream.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 43
Each class should declare at least one constructor 89203

org/apache/commons/imaging/common/itu_t4/HuffmanTree.java

Violation Line
Each class should declare at least one constructor 2690

org/apache/commons/imaging/common/itu_t4/T4_T6_Tables.java

Violation Line
Each class should declare at least one constructor 19262

org/apache/commons/imaging/common/mylzw/MyLzwCompressor.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 229

org/apache/commons/imaging/common/mylzw/MyLzwDecompressor.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 103
Consider using varargs for methods or constructors which take an array the last parameter. 107
Consider using varargs for methods or constructors which take an array the last parameter. 126

org/apache/commons/imaging/formats/bmp/BmpWriterRgb.java

Violation Line
Each class should declare at least one constructor 2578

org/apache/commons/imaging/formats/bmp/PixelParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 34

org/apache/commons/imaging/formats/bmp/PixelParserBitFields.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 40

org/apache/commons/imaging/formats/bmp/PixelParserRgb.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 31

org/apache/commons/imaging/formats/bmp/PixelParserRle.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 27

org/apache/commons/imaging/formats/bmp/PixelParserSimple.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 25

org/apache/commons/imaging/formats/dcx/DcxImageParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 114

org/apache/commons/imaging/formats/gif/GifImageParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 220
Consider using varargs for methods or constructors which take an array the last parameter. 610
Consider using varargs for methods or constructors which take an array the last parameter. 745
Avoid unused private methods such as 'writeAsSubBlocks(OutputStream,byte)'. 745
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1082

org/apache/commons/imaging/formats/gif/ImageDescriptor.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 39

org/apache/commons/imaging/formats/icns/IcnsDecoder.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 193

org/apache/commons/imaging/formats/icns/IcnsImageParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 177
Consider using varargs for methods or constructors which take an array the last parameter. 222

org/apache/commons/imaging/formats/icns/Rle24Compression.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 23

org/apache/commons/imaging/formats/ico/IcoImageParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 541

org/apache/commons/imaging/formats/jpeg/JpegImageMetadata.java

Violation Line
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 223

org/apache/commons/imaging/formats/jpeg/JpegImageParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 101
Consider using varargs for methods or constructors which take an array the last parameter. 144
Consider using varargs for methods or constructors which take an array the last parameter. 151
Consider using varargs for methods or constructors which take an array the last parameter. 408
Consider using varargs for methods or constructors which take an array the last parameter. 415
Consider using varargs for methods or constructors which take an array the last parameter. 447
Consider using varargs for methods or constructors which take an array the last parameter. 454
Consider using varargs for methods or constructors which take an array the last parameter. 486
Consider using varargs for methods or constructors which take an array the last parameter. 493
Consider using varargs for methods or constructors which take an array the last parameter. 536
Consider using varargs for methods or constructors which take an array the last parameter. 543

org/apache/commons/imaging/formats/jpeg/JpegUtils.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 41
Consider using varargs for methods or constructors which take an array the last parameter. 46
Consider using varargs for methods or constructors which take an array the last parameter. 171
Consider using varargs for methods or constructors which take an array the last parameter. 179

org/apache/commons/imaging/formats/jpeg/decoder/Dct.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 104
Consider using varargs for methods or constructors which take an array the last parameter. 110
Consider using varargs for methods or constructors which take an array the last parameter. 116
Consider using varargs for methods or constructors which take an array the last parameter. 125
Consider using varargs for methods or constructors which take an array the last parameter. 139
Consider using varargs for methods or constructors which take an array the last parameter. 180
Consider using varargs for methods or constructors which take an array the last parameter. 261
Consider using varargs for methods or constructors which take an array the last parameter. 308

org/apache/commons/imaging/formats/jpeg/decoder/JpegDecoder.java

Violation Line
Perhaps 'block' could be replaced by a local variable. 62
Consider using varargs for methods or constructors which take an array the last parameter. 68
Consider using varargs for methods or constructors which take an array the last parameter. 173
System.arraycopy is more efficient 212214
Consider using varargs for methods or constructors which take an array the last parameter. 243
Consider using varargs for methods or constructors which take an array the last parameter. 301

org/apache/commons/imaging/formats/jpeg/decoder/ZigZag.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 33
Consider using varargs for methods or constructors which take an array the last parameter. 39

org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 98
Consider using varargs for methods or constructors which take an array the last parameter. 116
Consider using varargs for methods or constructors which take an array the last parameter. 125
Consider using varargs for methods or constructors which take an array the last parameter. 151
Consider using varargs for methods or constructors which take an array the last parameter. 158
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 378
Consider using varargs for methods or constructors which take an array the last parameter. 498

org/apache/commons/imaging/formats/jpeg/iptc/IptcBlock.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 28

org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 50

org/apache/commons/imaging/formats/jpeg/iptc/JpegIptcRewriter.java

Violation Line
Each class should declare at least one constructor 41240

org/apache/commons/imaging/formats/jpeg/segments/App13Segment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 35

org/apache/commons/imaging/formats/jpeg/segments/App14Segment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 44

org/apache/commons/imaging/formats/jpeg/segments/App2Segment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 33

org/apache/commons/imaging/formats/jpeg/segments/ComSegment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 24

org/apache/commons/imaging/formats/jpeg/segments/DhtSegment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 46
Consider using varargs for methods or constructors which take an array the last parameter. 147
System.arraycopy is more efficient 164168

org/apache/commons/imaging/formats/jpeg/segments/DqtSegment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 37
Consider using varargs for methods or constructors which take an array the last parameter. 51

org/apache/commons/imaging/formats/jpeg/segments/GenericSegment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 35

org/apache/commons/imaging/formats/jpeg/segments/JfifSegment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 44

org/apache/commons/imaging/formats/jpeg/segments/SofnSegment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 49

org/apache/commons/imaging/formats/jpeg/segments/SosSegment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 46

org/apache/commons/imaging/formats/jpeg/segments/UnknownSegment.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 27

org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 93
Consider using varargs for methods or constructors which take an array the last parameter. 101
Consider using varargs for methods or constructors which take an array the last parameter. 165
Consider using varargs for methods or constructors which take an array the last parameter. 191
Consider using varargs for methods or constructors which take an array the last parameter. 198
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 299

org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 34
Consider using varargs for methods or constructors which take an array the last parameter. 38

org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpRewriter.java

Violation Line
Each class should declare at least one constructor 38204

org/apache/commons/imaging/formats/pcx/PcxConstants.java

Violation Line
Avoid modifiers which are implied by the context 19
Avoid modifiers which are implied by the context 20
Avoid modifiers which are implied by the context 21
Avoid modifiers which are implied by the context 23

org/apache/commons/imaging/formats/pcx/PcxImageParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 309

org/apache/commons/imaging/formats/pcx/PcxWriter.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 96

org/apache/commons/imaging/formats/png/PngColorType.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 38

org/apache/commons/imaging/formats/png/PngConstants.java

Violation Line
Avoid modifiers which are implied by the context 23
Avoid modifiers which are implied by the context 2526
Avoid modifiers which are implied by the context 28
Avoid modifiers which are implied by the context 29
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 35
Avoid modifiers which are implied by the context 36
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 70

org/apache/commons/imaging/formats/png/PngCrc.java

Violation Line
Each class should declare at least one constructor 2085
Consider using varargs for methods or constructors which take an array the last parameter. 53

org/apache/commons/imaging/formats/png/PngImageParser.java

Violation Line
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 97
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 98
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 99
Consider using varargs for methods or constructors which take an array the last parameter. 133

org/apache/commons/imaging/formats/png/PngWriter.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 72
Consider using varargs for methods or constructors which take an array the last parameter. 202
Avoid unused private methods such as 'writeChunkTRNS(OutputStream,Palette)'. 266
Consider using varargs for methods or constructors which take an array the last parameter. 280

org/apache/commons/imaging/formats/png/chunks/PngChunk.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 35

org/apache/commons/imaging/formats/png/chunks/PngChunkGama.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 27

org/apache/commons/imaging/formats/png/chunks/PngChunkIccp.java

Violation Line
Perhaps 'compressedProfile' could be replaced by a local variable. 31
Consider using varargs for methods or constructors which take an array the last parameter. 40

org/apache/commons/imaging/formats/png/chunks/PngChunkIdat.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 21

org/apache/commons/imaging/formats/png/chunks/PngChunkIhdr.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 37

org/apache/commons/imaging/formats/png/chunks/PngChunkItxt.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 46

org/apache/commons/imaging/formats/png/chunks/PngChunkPhys.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 29

org/apache/commons/imaging/formats/png/chunks/PngChunkPlte.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 30

org/apache/commons/imaging/formats/png/chunks/PngChunkText.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 30

org/apache/commons/imaging/formats/png/chunks/PngChunkZtxt.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 34

org/apache/commons/imaging/formats/png/chunks/PngTextChunk.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 23

org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilter.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 25

org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterAverage.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 30

org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterNone.java

Violation Line
Each class should declare at least one constructor 2329
Consider using varargs for methods or constructors which take an array the last parameter. 25

org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterPaeth.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 47

org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterSub.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 30

org/apache/commons/imaging/formats/png/scanlinefilters/ScanlineFilterUp.java

Violation Line
Each class should declare at least one constructor 2343
Consider using varargs for methods or constructors which take an array the last parameter. 25

org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilter.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 27

org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterGrayscale.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 29

org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterIndexedColor.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 25

org/apache/commons/imaging/formats/png/transparencyfilters/TransparencyFilterTrueColor.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 29

org/apache/commons/imaging/formats/pnm/PamFileInfo.java

Violation Line
Each class should declare at least one constructor 111114
Each class should declare at least one constructor 146173

org/apache/commons/imaging/formats/pnm/PamWriter.java

Violation Line
Each class should declare at least one constructor 2772

org/apache/commons/imaging/formats/pnm/PbmWriter.java

Violation Line
Private field 'rawbits' could be made final; it is only initialized in the declaration or constructor. 28

org/apache/commons/imaging/formats/pnm/PgmWriter.java

Violation Line
Private field 'rawbits' could be made final; it is only initialized in the declaration or constructor. 28

org/apache/commons/imaging/formats/pnm/PpmWriter.java

Violation Line
Private field 'rawbits' could be made final; it is only initialized in the declaration or constructor. 28

org/apache/commons/imaging/formats/psd/ImageResourceBlock.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 28

org/apache/commons/imaging/formats/psd/ImageResourceType.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 125
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 126
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 128

org/apache/commons/imaging/formats/psd/PsdImageParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 170
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 420
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 740
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 758

org/apache/commons/imaging/formats/psd/dataparsers/DataParser.java

Violation Line
Each class should declare at least one constructor 2545

org/apache/commons/imaging/formats/psd/dataparsers/DataParserBitmap.java

Violation Line
Each class should declare at least one constructor 2146

org/apache/commons/imaging/formats/psd/dataparsers/DataParserCmyk.java

Violation Line
Each class should declare at least one constructor 2245

org/apache/commons/imaging/formats/psd/dataparsers/DataParserGrayscale.java

Violation Line
Each class should declare at least one constructor 2139

org/apache/commons/imaging/formats/psd/dataparsers/DataParserIndexed.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 24

org/apache/commons/imaging/formats/psd/dataparsers/DataParserLab.java

Violation Line
Each class should declare at least one constructor 2240

org/apache/commons/imaging/formats/psd/dataparsers/DataParserRgb.java

Violation Line
Each class should declare at least one constructor 2141

org/apache/commons/imaging/formats/psd/dataparsers/DataParserStub.java

Violation Line
Each class should declare at least one constructor 2133

org/apache/commons/imaging/formats/psd/datareaders/CompressedDataReader.java

Violation Line
Private field 'dataParser' could be made final; it is only initialized in the declaration or constructor. 38

org/apache/commons/imaging/formats/psd/datareaders/DataReader.java

Violation Line
Avoid unused imports such as 'org.apache.commons.imaging.formats.psd.dataparsers.DataParser' 26

org/apache/commons/imaging/formats/psd/datareaders/UncompressedDataReader.java

Violation Line
Private field 'dataParser' could be made final; it is only initialized in the declaration or constructor. 35

org/apache/commons/imaging/formats/rgbe/RgbeInfo.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 170

org/apache/commons/imaging/formats/tiff/JpegImageData.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 21

org/apache/commons/imaging/formats/tiff/TiffElement.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 50

org/apache/commons/imaging/formats/tiff/TiffField.java

Violation Line
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 176
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 526527
System.arraycopy is more efficient 629631
System.arraycopy is more efficient 636638
System.arraycopy is more efficient 643645

org/apache/commons/imaging/formats/tiff/TiffImageData.java

Violation Line
Each class should declare at least one constructor 30179
Consider using varargs for methods or constructors which take an array the last parameter. 146

org/apache/commons/imaging/formats/tiff/TiffImageMetadata.java

Violation Line
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 548551
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 552555

org/apache/commons/imaging/formats/tiff/TiffImageParser.java

Violation Line
Each class should declare at least one constructor 58737
Unnecessary use of fully qualified name 'TiffConstants.PARAM_KEY_SUBIMAGE_X' due to existing import 'org.apache.commons.imaging.formats.tiff.constants.TiffConstants' 513
Unnecessary use of fully qualified name 'TiffConstants.PARAM_KEY_SUBIMAGE_Y' due to existing import 'org.apache.commons.imaging.formats.tiff.constants.TiffConstants' 514
Unnecessary use of fully qualified name 'TiffConstants.PARAM_KEY_SUBIMAGE_WIDTH' due to existing import 'org.apache.commons.imaging.formats.tiff.constants.TiffConstants' 515
Unnecessary use of fully qualified name 'TiffConstants.PARAM_KEY_SUBIMAGE_HEIGHT' due to existing import 'org.apache.commons.imaging.formats.tiff.constants.TiffConstants' 516
StringBuffer constructor is initialized with size 16, but has at least 23 characters appended. 536

org/apache/commons/imaging/formats/tiff/TiffReader.java

Violation Line
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 392
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 405

org/apache/commons/imaging/formats/tiff/datareaders/DataReader.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 97
Consider using varargs for methods or constructors which take an array the last parameter. 120

org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeLong.java

Violation Line
System.arraycopy is more efficient 5052

org/apache/commons/imaging/formats/tiff/photometricinterpreters/PhotometricInterpreterPalette.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 34

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoAscii.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 32

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoDouble.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 30

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoFloat.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 30

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoLong.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 35

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoLongOrIFD.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 35

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoRational.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 31

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoSLong.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 30

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoSRational.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 31

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoSShort.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 30

org/apache/commons/imaging/formats/tiff/taginfos/TagInfoShort.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 30

org/apache/commons/imaging/formats/tiff/write/TiffImageWriterLossless.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 59
Consider using varargs for methods or constructors which take an array the last parameter. 63

org/apache/commons/imaging/formats/tiff/write/TiffOutputField.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 41
Consider using varargs for methods or constructors which take an array the last parameter. 46
Consider using varargs for methods or constructors which take an array the last parameter. 105
Consider using varargs for methods or constructors which take an array the last parameter. 109
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 139
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 140
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 141
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 143
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 144
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 145
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 146
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 148
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 149

org/apache/commons/imaging/formats/tiff/write/TiffOutputItem.java

Violation Line
Each class should declare at least one constructor 2477
Consider using varargs for methods or constructors which take an array the last parameter. 48
Consider using varargs for methods or constructors which take an array the last parameter. 63

org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java

Violation Line
Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 4554
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 260
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 261
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 262
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 264
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 265
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 266
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 281
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 283

org/apache/commons/imaging/formats/wbmp/WbmpImageParser.java

Violation Line
Each class should declare at least one constructor 47294

org/apache/commons/imaging/formats/xbm/XbmImageParser.java

Violation Line
Each class should declare at least one constructor 52413

org/apache/commons/imaging/icc/IccProfileInfo.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 50

org/apache/commons/imaging/icc/IccProfileParser.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 47
Consider using varargs for methods or constructors which take an array the last parameter. 294

org/apache/commons/imaging/icc/IccTag.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 50

org/apache/commons/imaging/icc/IccTagDataType.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 29

org/apache/commons/imaging/icc/IccTagDataTypes.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 32
Consider using varargs for methods or constructors which take an array the last parameter. 58
Consider using varargs for methods or constructors which take an array the last parameter. 76
Consider using varargs for methods or constructors which take an array the last parameter. 94
Consider using varargs for methods or constructors which take an array the last parameter. 124

org/apache/commons/imaging/palette/ColorGroup.java

Violation Line
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 53

org/apache/commons/imaging/palette/ColorSpaceSubset.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 48
Consider using varargs for methods or constructors which take an array the last parameter. 134

org/apache/commons/imaging/palette/LongestAxisMedianCut.java

Violation Line
Each class should declare at least one constructor 26139

org/apache/commons/imaging/palette/MedianCutPalette.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 22

org/apache/commons/imaging/palette/MostPopulatedBoxesMedianCut.java

Violation Line
Each class should declare at least one constructor 27162

org/apache/commons/imaging/palette/Palette.java

Violation Line
Avoid unused imports such as 'org.apache.commons.imaging.util.Debug' 20

org/apache/commons/imaging/palette/PaletteFactory.java

Violation Line
Each class should declare at least one constructor 34531
Consider using varargs for methods or constructors which take an array the last parameter. 480

org/apache/commons/imaging/palette/SimplePalette.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 22

org/apache/commons/imaging/util/Debug.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 49
Consider using varargs for methods or constructors which take an array the last parameter. 64
Consider using varargs for methods or constructors which take an array the last parameter. 99
StringBuffer constructor is initialized with size 16, but has at least 18 characters appended. 119
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 150
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 151
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 152
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 153
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 154
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 155
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 156
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 157
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 158
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 159
Consider using varargs for methods or constructors which take an array the last parameter. 193
Consider using varargs for methods or constructors which take an array the last parameter. 197
Consider using varargs for methods or constructors which take an array the last parameter. 224
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 261
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 262264
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 265
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 266
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 268
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 270
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 271