Apache Commons logo Commons Imaging

Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag Class Total number of occurrences Tag strings used by tag class
Needs Work 65 TODO, FIXME, XXX
Noteable Markers 9 NOTE, NOPMD, NOSONAR

Each tag is detailed below:

Needs Work

Number of occurrences found in the code: 65

org.apache.commons.imaging.AbstractImageParser Line
this doesn't look like we're actually getting all images contained in the given ByteSource... 259
org.apache.commons.imaging.ColorTools Line
"This class is a mess and needs to be cleaned up." </p> 40
org.apache.commons.imaging.ImagingGuessFormatTest Line
(cmchen): add ability to sniff ICOs if possible. new Object[] { ImageFormat.IMAGE_FORMAT_ICO, ICO_IMAGE_FILE }, 49
(cmchen): add ability to sniff TGAs if possible. new Object[] { ImageFormat.IMAGE_FORMAT_TGA, TGA_IMAGE_FILE }, 55
(cmchen): Add test images for these formats. new Object[] { ImageFormat.IMAGE_FORMAT_PNM, PNM_IMAGE_FILE }, new Object[] { ImageFormat.IMAGE_FORMAT_JBIG2, JBIG2_IMAGE_FILE }, 57
org.apache.commons.imaging.bytesource.ByteSourceImageTest Line
not all adapters count images yet. assertTrue(imageInfoFile.getNumberOfImages() > 0); 141
org.apache.commons.imaging.common.BasicCParser Line
replace this by a parser generated via ANTLR (if we really need it?!) 32
org.apache.commons.imaging.common.RationalNumberTest Line
assert something here, the following will fail for some values. Do we have a bug? assertEquals(0.0, difference, 0.0d); 118
org.apache.commons.imaging.formats.bmp.BmpImageParser Line
comments... 194
this should throw UnsupportedOperationException, but RoundtripTest has to be refactored completely before this can be changed 236
org.apache.commons.imaging.formats.bmp.BmpReadTest Line
assert more 49
assert more 69
org.apache.commons.imaging.formats.dcx.DcxImageParser Line
should throw UOE 120
should throw UOE 126
should throw UOE 132
should throw UOE 138
org.apache.commons.imaging.formats.dcx.DcxReadTest Line
assert more 43
org.apache.commons.imaging.formats.gif.GifImageParser Line
--No comment-- 898
--No comment-- 1008
org.apache.commons.imaging.formats.gif.GifReadTest Line
assert more 61
assert more 140
org.apache.commons.imaging.formats.icns.IcnsImageParser Line
should throw UOE 182
org.apache.commons.imaging.formats.icns.IcnsReadTest Line
assert more 65
org.apache.commons.imaging.formats.ico.IcoImageParser Line
should throw UOE 292
should throw UOE 298
should throw UOE 304
should throw UOE 310
org.apache.commons.imaging.formats.ico.IcoReadTest Line
assert more 43
org.apache.commons.imaging.formats.jpeg.JpegImageParser Line
concatenate if multiple segments, need example. 258
we ought to count images, but don't yet. 450
inaccurate. 456
org.apache.commons.imaging.formats.jpeg.JpegReadTest Line
only run this tests with images that have metadata... assertNotNull(metadata); 51
org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder Line
optimize 330
why do images come out too bright with CS_GRAY? colorModel = new ComponentColorModel( ColorSpace.getInstance(ColorSpace.CS_GRAY), false, true, Transparency.OPAQUE, DataBuffer.TYPE_BYTE); raster = colorModel.createCompatibleWritableRaster( sofnSegment.width, sofnSegment.height); 460
org.apache.commons.imaging.formats.jpeg.exif.ExifDumpTest Line
assert something 46
assert more 56
org.apache.commons.imaging.formats.jpeg.exif.ExifRewriter Line
add support for adding, not just replacing. throw new ImageReadException("No APP1 EXIF segment found."); } 172
org.apache.commons.imaging.formats.jpeg.exif.GpsTest Line
we should assert something here. 64
org.apache.commons.imaging.formats.jpeg.exif.MakerNoteFieldTest Line
assert something 47
org.apache.commons.imaging.formats.jpeg.exif.TextFieldTest Line
what else to assert? 49
org.apache.commons.imaging.formats.jpeg.iptc.IptcAddTest Line
select only files with meta for this test 54
org.apache.commons.imaging.formats.jpeg.iptc.IptcParser Line
make sure order right 423
org.apache.commons.imaging.formats.jpeg.iptc.IptcUpdateTest Line
should either be null or empty 135
org.apache.commons.imaging.formats.jpeg.xmp.JpegXmpDumpTest Line
assert more 44
org.apache.commons.imaging.formats.pcx.PcxWriter Line
What's the right thing to do here for a null palette? 119
org.apache.commons.imaging.formats.png.PngColorType Line
can this be merged with ImageInfo.ColorType? 24
org.apache.commons.imaging.formats.png.PngImageParser Line
should this be a clone? 407
I have been too casual about making inner classes subclass of BinaryFileParser I may not have always preserved byte order correctly. 644
org.apache.commons.imaging.formats.png.transparencyfilters.TransparencyFilterIndexedColor Line
see below - is this check correct? 32
check for > length cannot be true because of check above 36
org.apache.commons.imaging.formats.psd.ImageResourceType Line
Turn into an enum 20
org.apache.commons.imaging.formats.psd.PsdImageParser Line
comments... 334
inaccurate. 359
org.apache.commons.imaging.formats.tiff.TiffImageParser Line
wrong 480
org.apache.commons.imaging.formats.tiff.TiffLzwTest Line
fails with java.io.IOException: Bad Code: -1 codes: 258 code_size: 9, table: 4096 218
org.apache.commons.imaging.formats.tiff.constants.ExifTagConstants Line
other types? 91
org.apache.commons.imaging.formats.tiff.constants.MicrosoftHdPhotoTagConstants Line
might be an offset? 120
might be an offset? 125
org.apache.commons.imaging.formats.tiff.constants.TiffDirectoryConstants Line
this should really be an enum 38
org.apache.commons.imaging.formats.tiff.constants.TiffTagConstants Line
--No comment-- 300
org.apache.commons.imaging.formats.tiff.itu_t4.BitInputStreamFlexible Line
should be byte order conscious, that is, TIFF for reading samples size < 8 - shouldn't that effect their order within byte? 29
org.apache.commons.imaging.formats.webp.WebPImageParser Line
this does not look too risky; a user could craft an image with millions of chunks, that are really expensive to dump, but that should result in a large image, where we can short- -circuit the operation somewhere else - if needed. 176
org.apache.commons.imaging.icc.IccProfileParser Line
Throw instead of logging? 55
org.apache.commons.imaging.internal.ImageParserFactory Line
circular dependency between Imaging and internal Util class below. 39
org.apache.commons.imaging.mylzw.MyBitOutputStream Line
in and out streams CANNOT accurately read/write 32bits at a time, as int will overflow. should have used a long 66

Noteable Markers

Number of occurrences found in the code: 9

org.apache.commons.imaging.common.BasicCParser Line
--No comment-- 437
org.apache.commons.imaging.common.PackBits Line
--No comment-- 146
org.apache.commons.imaging.formats.jpeg.JpegImageMetadata Line
--No comment-- 101
org.apache.commons.imaging.formats.jpeg.iptc.IptcParserTest Line
We use the JpegParser, so it will send only the block/segment that IptcParser needs for the test image 129
org.apache.commons.imaging.formats.tiff.TiffFloatingPointRoundTripTest Line
At this time, Tile format is not supported. When it is, modify the tags below to populate TIFF_TAG_TILE_* appropriately. 278
org.apache.commons.imaging.formats.tiff.TiffRoundTripInt32Test Line
At this time, Tile format is not supported. When it is, modify the tags below to populate TIFF_TAG_TILE_* appropriately. 176
org.apache.commons.imaging.formats.tiff.TiffShortIntRoundTripTest Line
At this time, Tile format is not supported. When it is, modify the tags below to populate TIFF_TAG_TILE_* appropriately. 173
org.apache.commons.imaging.formats.tiff.itu_t4.T4AndT6Compression Line
--No comment-- 638
org.apache.commons.imaging.formats.webp.WebPImageParser Line
How can we do this better? 122