Apache Commons logo Commons Imaging™ logo

Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag Class Total number of occurrences Tag strings used by tag class
Needs Work 63 TODO, FIXME, XXX
Noteable Markers 7 NOTE, NOPMD, NOSONAR

Each tag is detailed below:

Needs Work

Number of occurrences found in the code: 63

org.apache.commons.imaging.ImageParser Line
this doesn't look like we're actually getting all images contained in the given ByteSource... 453
org.apache.commons.imaging.ImagingGuessFormatTest Line
(cmchen): add ability to sniff ICOs if possible. new Object[] { ImageFormat.IMAGE_FORMAT_ICO, ICO_IMAGE_FILE }, 51
(cmchen): add ability to sniff TGAs if possible. new Object[] { ImageFormat.IMAGE_FORMAT_TGA, TGA_IMAGE_FILE }, 60
(cmchen): Add test images for these formats. new Object[] { ImageFormat.IMAGE_FORMAT_PNM, PNM_IMAGE_FILE }, new Object[] { ImageFormat.IMAGE_FORMAT_JBIG2, JBIG2_IMAGE_FILE }, 62
org.apache.commons.imaging.common.BasicCParser Line
replace this by a parser generated via ANTLR (if we really need it?!) 32
org.apache.commons.imaging.common.RationalNumberTest Line
assert something here, the following will fail for some values. Do we have a bug? assertEquals(0.0, difference, 0.0d); 119
org.apache.commons.imaging.common.bytesource.ByteSourceImageTest Line
not all adapters count images yet. assertTrue(imageInfoFile.getNumberOfImages() > 0); 219
org.apache.commons.imaging.common.itu_t4.BitInputStreamFlexible Line
should be byte order conscious, ie TIFF for reading samples size<8 - shouldn't that effect their order within byte? 28
org.apache.commons.imaging.common.mylzw.MyBitOutputStream Line
in and out streams CANNOT accurately read/write 32bits at a time, as int will overflow. should have used a long 40
org.apache.commons.imaging.formats.bmp.BmpImageParser Line
this should throw UnsupportedOperationException, but RoundtripTest has to be refactored completely before this can be changed 509
comments... 555
org.apache.commons.imaging.formats.bmp.BmpReadTest Line
assert more 49
assert more 64
org.apache.commons.imaging.formats.dcx.DcxImageParser Line
should throw UOE 78
should throw UOE 85
should throw UOE 92
should throw UOE 99
org.apache.commons.imaging.formats.dcx.DcxReadTest Line
assert more 57
org.apache.commons.imaging.formats.gif.GifImageParser Line
--No comment-- 906
--No comment-- 1021
org.apache.commons.imaging.formats.gif.GifReadTest Line
assert more 67
assert more 99
org.apache.commons.imaging.formats.icns.IcnsImageParser Line
should throw UOE 76
org.apache.commons.imaging.formats.icns.IcnsReadTest Line
assert more 81
org.apache.commons.imaging.formats.ico.IcoImageParser Line
should throw UOE 85
should throw UOE 92
should throw UOE 99
should throw UOE 106
org.apache.commons.imaging.formats.ico.IcoReadTest Line
assert more 57
org.apache.commons.imaging.formats.jpeg.JpegImageParser Line
concatenate if multiple segments, need example. 379
inaccurate. 813
org.apache.commons.imaging.formats.jpeg.JpegReadTest Line
only run this tests with images that have metadata... assertNotNull(metadata); 50
org.apache.commons.imaging.formats.jpeg.decoder.JpegDecoder Line
why do images come out too bright with CS_GRAY? colorModel = new ComponentColorModel( ColorSpace.getInstance(ColorSpace.CS_GRAY), false, true, Transparency.OPAQUE, DataBuffer.TYPE_BYTE); raster = colorModel.createCompatibleWritableRaster( sofnSegment.width, sofnSegment.height); 134
optimize 307
org.apache.commons.imaging.formats.jpeg.exif.ExifDumpTest Line
assert something 47
assert more 57
org.apache.commons.imaging.formats.jpeg.exif.ExifRewriter Line
add support for multiple segments throw new ImageReadException( "More than one APP1 EXIF segment."); 168
add support for adding, not just replacing. throw new ImageReadException("No APP1 EXIF segment found."); } 186
org.apache.commons.imaging.formats.jpeg.exif.GpsTest Line
we should assert something here. 58
org.apache.commons.imaging.formats.jpeg.exif.MakerNoteFieldTest Line
assert something 49
org.apache.commons.imaging.formats.jpeg.exif.TextFieldTest Line
what else to assert? 52
org.apache.commons.imaging.formats.jpeg.iptc.IptcAddTest Line
select only files with meta for this test 58
org.apache.commons.imaging.formats.jpeg.iptc.IptcParser Line
make sure order right 453
org.apache.commons.imaging.formats.jpeg.iptc.IptcUpdateTest Line
should either be null or empty 68
org.apache.commons.imaging.formats.jpeg.xmp.JpegXmpDumpTest Line
assert more 45
org.apache.commons.imaging.formats.png.PngColorType Line
can this be merged with ImageInfo.ColorType? 24
org.apache.commons.imaging.formats.png.PngImageParser Line
should this be a clone? 261
I have been too casual about making inner classes subclass of BinaryFileParser I may not have always preserved byte order correctly. 314
org.apache.commons.imaging.formats.png.transparencyfilters.TransparencyFilterIndexedColor Line
see below - is this check correct? 32
check for > length cannot be true because of check above 36
org.apache.commons.imaging.formats.psd.ImageResourceType Line
Turn into an enum 20
org.apache.commons.imaging.formats.psd.PsdImageParser Line
comments... 459
inaccurate. 484
for PSD 7 and later, verify "XMP" name. for (int i = 0; i < blocks.size(); i++) { final ImageResourceBlock block = blocks.get(i); if (!block.getName().equals(BLOCK_NAME_XMP)) { continue; } xmpBlocks.add(block); } } else { 683
org.apache.commons.imaging.formats.tiff.TiffImageParser Line
wrong 263
org.apache.commons.imaging.formats.tiff.TiffLzwTest Line
fails with java.io.IOException: Bad Code: -1 codes: 258 code_size: 9, table: 4096 60
org.apache.commons.imaging.formats.tiff.constants.ExifTagConstants Line
other types? 131
org.apache.commons.imaging.formats.tiff.constants.MicrosoftHdPhotoTagConstants Line
might be an offset? 193
might be an offset? 202
org.apache.commons.imaging.formats.tiff.constants.TiffDirectoryConstants Line
this should really be an enum 38
org.apache.commons.imaging.formats.tiff.constants.TiffTagConstants Line
--No comment-- 439
org.apache.commons.imaging.internal.Util Line
circular dependency between Imaging and internal Util class below. 58
org.apache.commons.imaging.palette.Palette Line
shouldn't it be an ImageReadException for getPaletteIndex? 26

Noteable Markers

Number of occurrences found in the code: 7

org.apache.commons.imaging.formats.jpeg.JpegImageMetadata Line
--No comment-- 149
org.apache.commons.imaging.formats.jpeg.iptc.IptcParserTest Line
We use the JpegParser, so it will send only the block/segment that IptcParser needs for the test image 95
org.apache.commons.imaging.formats.jpeg.segments.ComSegment Line
--No comment-- 45
org.apache.commons.imaging.formats.tiff.TiffFloatingPointRoundTripTest Line
At this time, Tile format is not supported. When it is, modify the tags below to populate TIFF_TAG_TILE_* appropriately. 193
org.apache.commons.imaging.formats.tiff.TiffRoundTripInt32Test Line
At this time, Tile format is not supported. When it is, modify the tags below to populate TIFF_TAG_TILE_* appropriately. 142
org.apache.commons.imaging.formats.tiff.TiffShortIntRoundTripTest Line
At this time, Tile format is not supported. When it is, modify the tags below to populate TIFF_TAG_TILE_* appropriately. 142
org.apache.commons.imaging.icc.IccProfileParser Line
we're doing nothing with the data 244